Add resource-level configuration for custom active states in min active replica check #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // Determine which states should be considered "unhealthy" (not active) | ||
| Set<String> unhealthyStates = getUnhealthyStates(dataAccessor, propertyKeyBuilder, |
Collaborator
There was a problem hiding this comment.
fetch statemodel defintion inside this method only.
Collaborator
|
I think we need a resource validator in ResourceAccessor which validates resource configs before updating the configs. |
Collaborator
|
LGTM However, I feel we should add resource config validator before adding this configurations. Adding guard rails in Helix rest is an AI of Helix Ring discovery. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This PR adds support for resource-level configuration of which replica states are considered "active" for the min active replica check in the stoppable check API.
(apache#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)
Description
(Write a concise description including what, why, how)
Different state models have different semantics for which states should be considered "healthy" or "active". For example:
• In IndexerStateModel: Only CAUGHT_UP replicas should be considered active.
• In AmbryLeaderStandby: Only LEADER and STANDBY should be considered active.
Previously, Helix used a hardcoded default where all states except DROPPED, ERROR, and initialState were considered active. This PR allows users to customize this behavior per resource. The default behavior is preserved, but can now be overridden using the new ACTIVE_STATES_FOR_MIN_ACTIVE_REPLICA_CHECK property in ResourceConfig.
Tests
New Integration tests
(List the names of added unit/integration tests)
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)